New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Input.tsx #102
Merged
Merged
Update Input.tsx #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type parameter from `input` properties -- type
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Good catch, thanks for finding this @mikeyGlitz! I don't mind having all types available even though they're already covered. That way users have the option to use for everything and ignore the other components. |
benjitrosch
approved these changes
Apr 25, 2022
This was referenced Jun 30, 2022
This was referenced Aug 16, 2022
This was referenced Sep 5, 2022
This was referenced Oct 31, 2022
This was referenced Dec 30, 2022
This was referenced Apr 4, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the feature requested in #101 where the IDE presents a
type
attribute forInput
, however whenever an Input is rendered, itstype
attribute will always betext
.Further recommendations would be to implement a custom type where a limited selection of "types" may be selected for input
i.e.
The point being her would be to remove types like
checkbox
andbutton
from the list of selectable "inputs" since they're already covered by other components.